[SYCL][E2E][BINDLESS] Add ptr to ptr of image_handle test failing on level zero only #18721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JackAKirk <[email protected]>
Signed-off-by: JackAKirk <[email protected]>
ProGTX
reviewed
May 29, 2025
Signed-off-by: JackAKirk <[email protected]>
Signed-off-by: JackAKirk <[email protected]>
Signed-off-by: JackAKirk <[email protected]>
switch to sampled_image_handle example Signed-off-by: JackAKirk <[email protected]>
Signed-off-by: JackAKirk <[email protected]>
ProGTX
approved these changes
Jun 11, 2025
|
@intel/llvm-gatekeepers this is ready to merge. Thanks |
kbenzie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test passes on the cuda backend but fails on level_zero. It allocates a single element array of
unsampled_image_handle*, pointing to a validunsampled_image_handlethat is dereferenced on the device. The casting to genericvoid*is not necessary to make the test fail on l0, but is done to keep this test matching the original bug report we received.Note that rewriting this test to make an identical dereference with for example a single 2d C array of
longpasses on level_zero, indicating that this issue is specific to image_handles.